zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] joshelser commented on a change in pull request #784: ZOOKEEPER-974: Allow a configurable ZooKeeper server socket listen ba…
Date Mon, 28 Jan 2019 17:50:30 GMT
joshelser commented on a change in pull request #784: ZOOKEEPER-974: Allow a configurable ZooKeeper
server socket listen ba…
URL: https://github.com/apache/zookeeper/pull/784#discussion_r251523760
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServerConf.java
 ##########
 @@ -60,6 +60,12 @@
      * The key in the map returned by {@link #toMap()} for the server ID.
      */
     public static final String KEY_SERVER_ID = "server_id";
+    /**
+     * The key in the map returned by {@link #toMap()} for the server socket
+     * listen backlog.
+     */
+    public static final String KEY_CLIENT_PORT_LISTEN_BACKLOG
 
 Review comment:
   To be honest, I really don't get it either :). I was really confused what the intention
was in configuration object layering. For real installations, we seem to start from a QuorumPeerConf,
but then pass this into ZooKeeperServer? Is QPC meant for quorums whereas ZKC would be relevant
for just a single-server instance? Need to do more digging..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message