zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now supports reading rules from a file
Date Mon, 28 Jan 2019 07:08:14 GMT
arshadmohammad commented on a change in pull request #324: ZOOKEEPER-2843: auth_to_local now
supports reading rules from a file
URL: https://github.com/apache/zookeeper/pull/324#discussion_r251299481
 
 

 ##########
 File path: src/java/main/org/apache/zookeeper/server/auth/KerberosName.java
 ##########
 @@ -356,6 +358,9 @@ String apply(String[] params) throws IOException {
    */
   public static void setConfiguration() throws IOException {
 
 Review comment:
   thrown IOException should be logged. So can you include this exception where it is re thrown
i.e. 
    `
   ...
   ...
   setConfiguration();
       }
       catch (IOException e) {
         throw new IllegalArgumentException("Could not configure Kerberos principal name mapping.",
e);
       }`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message