zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on a change in pull request #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4
Date Thu, 17 Jan 2019 22:08:55 GMT
eolivelli commented on a change in pull request #764: ZOOKEEPER-3223: Configure Spotbugs -
on branch 3.4
URL: https://github.com/apache/zookeeper/pull/764#discussion_r248853664
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/persistence/FileTxnLog.java
 ##########
 @@ -152,10 +152,10 @@ public static void setPreallocSize(long size) {
      * Setter for ServerStats to monitor fsync threshold exceed
      * @param serverStats used to update fsyncThresholdExceedCount
      */
-     @Override
-     public void setServerStats(ServerStats serverStats) {
-         this.serverStats = serverStats;
-     }
+    @Override
+    public synchronized void setServerStats(ServerStats serverStats) {
 
 Review comment:
   @anmolnar this one can stay, it is innocuous

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message