zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4
Date Wed, 16 Jan 2019 13:18:44 GMT
eolivelli commented on issue #764: ZOOKEEPER-3223: Configure Spotbugs - on branch 3.4
URL: https://github.com/apache/zookeeper/pull/764#issuecomment-454775677
 
 
   @anmolnar thank you for your review
   
   You are suggesting me to add a bunch of SuppressFBWarnings and do not add so many synchronized
blocks, aren't you ?
   Do you want me to drop all of them or only the most dangerous ?
   
   Code is currently working well (before this patch) and I suppose it will continue to work
even without those new "synchronized" blocks.
   
   I will wait a second "ack" from you and then I will fix the patch as soon as possible so
that we can move forward with Maven migration.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message