zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] nkalmar commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create maven assembly
Date Wed, 16 Jan 2019 09:01:45 GMT
nkalmar commented on a change in pull request #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#discussion_r248197284
 
 

 ##########
 File path: src/assembly/jar.xml
 ##########
 @@ -0,0 +1,65 @@
+<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"
+          xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+          xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd">
+
+  <id>jar</id>
 
 Review comment:
   Yes, that was the goal. Originally, we said we will reproduce ant build as much as possible.
It has this fatjar in it.
   
   I will do some revision on this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message