zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on 3.5 after applying Java 11 fix
Date Fri, 04 Jan 2019 15:24:59 GMT
eolivelli commented on issue #753: ZOOKEEPER-3204: Reconfig tests are constantly failing on
3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#issuecomment-451474494
 
 
   I will answer to the mailing list as well.
   
   I have thought more about this problem, and I have checked that Netty 3 is really dead/unmantained
(last release in 2016).
   If I understand correctly there is no easy workaround (nothing without hacking Netty 3
internals)
   
   As soon as we will declare 3.5.5 "stable" the world will hopefully abandon 3.4 and switch
to 3.5 + Netty (because of SSL support).
   The network stack is very important so it is better to have Netty 4 as foundation, I am
thinking about security issues, we won't make an "hotfix" release with the switch to Netty
4 because there is a bad bug in Netty 3.
   So better to switch now.
   
   But Facebooks guys, expecially @ivmaykov  did a lot of bugfixes around Netty on master
branch, we must be sure that what we are delivering in 3.5.5 is stable.
   
   We will also have to state clearly in the "release notes" that Netty version is changed,
as this may have a non trivial impact to memory usage (i.e. Netty 4 uses more Direct memory
by default)
   
   So after all if we take care of porting all of the changes about Netty 4 from master I
am +1 to this patch
   
   @anmolnar @nkalmar 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message