zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs
Date Thu, 03 Jan 2019 10:49:07 GMT
anmolnar commented on a change in pull request #742: ZOOKEEPER-3223: Configure Spotbugs
URL: https://github.com/apache/zookeeper/pull/742#discussion_r244963490
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/EphemeralType.java
 ##########
 @@ -212,7 +212,8 @@ public static void validateServerId(long serverId) {
      */
     public static void validateTTL(CreateMode mode, long ttl) {
         if (mode.isTTL()) {
-            TTL.toEphemeralOwner(ttl);
+            // nothing to do in 3.5 was:
+            // TTL.toEphemeralOwner(ttl);
 
 Review comment:
   @eolivelli How is this code change related to this patch?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message