From dev-return-76844-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sat Dec 29 05:07:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83DF418077A for ; Sat, 29 Dec 2018 05:07:04 +0100 (CET) Received: (qmail 75485 invoked by uid 500); 29 Dec 2018 04:07:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 75472 invoked by uid 99); 29 Dec 2018 04:07:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 29 Dec 2018 04:07:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 8A96BCE9E6 for ; Sat, 29 Dec 2018 04:07:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1ijfg4UmEELF for ; Sat, 29 Dec 2018 04:07:00 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C0CB661063 for ; Sat, 29 Dec 2018 04:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 64521E0115 for ; Sat, 29 Dec 2018 04:07:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2023F2536C for ; Sat, 29 Dec 2018 04:07:00 +0000 (UTC) Date: Sat, 29 Dec 2018 04:07:00 +0000 (UTC) From: "Jiafu Jiang (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (ZOOKEEPER-3231) Purge task may lost data when we have many invalid snapshot files. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3231?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiafu Jiang updated ZOOKEEPER-3231: ----------------------------------- Description:=20 I=C2=A0read the ZooKeeper source code, and I find the purge task use=C2=A0F= ileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does n= ot check whether the snapshots are valid. Consider a worse case, a ZooKeeper server may have many invalid snapshots, = and when a purge task begins, it will use the zxid in the last snapshot fil= e name to purge old snapshots or transaction logs, then we may lost data.= =C2=A0 I think we should use=C2=A0FileSnap#findNValidSnapshots(int)=C2=A0instead o= f FileSnap#findNRecentSnapshots in=C2=A0FileTxnSnapLog#findNRecentSnapshots= . I am not sure. =C2=A0 was: I=C2=A0read the ZooKeeper source code, and I find the purge task use=C2=A0F= ileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method does n= ot check whether the snapshots are valid. Consider a worse case, a ZooKeeper server may have many invalid snapshots, = and when a purge task begins, is will use the zxid in the last snapshot fil= e name to purge old snapshots or transaction logs, then we may lost data.= =C2=A0 I think we should use=C2=A0FileSnap#findNValidSnapshots(int)=C2=A0instead o= f FileSnap#findNRecentSnapshots in=C2=A0FileTxnSnapLog#findNRecentSnapshots= . I am not sure. =C2=A0 > Purge task may lost data when we have many invalid snapshot files. > ------------------------------------------------------------------- > > Key: ZOOKEEPER-3231 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3231 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.4, 3.4.13 > Reporter: Jiafu Jiang > Priority: Major > > I=C2=A0read the ZooKeeper source code, and I find the purge task use=C2= =A0FileTxnSnapLog#findNRecentSnapshots to find snapshots, but the method do= es not check whether the snapshots are valid. > Consider a worse case, a ZooKeeper server may have many invalid snapshots= , and when a purge task begins, it will use the zxid in the last snapshot f= ile name to purge old snapshots or transaction logs, then we may lost data.= =C2=A0 > I think we should use=C2=A0FileSnap#findNValidSnapshots(int)=C2=A0instead= of FileSnap#findNRecentSnapshots in=C2=A0FileTxnSnapLog#findNRecentSnapsho= ts. I am not sure. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)