From dev-return-76710-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Dec 18 00:23:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5BD1180652 for ; Tue, 18 Dec 2018 00:23:03 +0100 (CET) Received: (qmail 31182 invoked by uid 500); 17 Dec 2018 23:23:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 31170 invoked by uid 99); 17 Dec 2018 23:23:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Dec 2018 23:23:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 7A264C056A for ; Mon, 17 Dec 2018 23:23:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Trkv8LXsplhM for ; Mon, 17 Dec 2018 23:23:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D971760FE2 for ; Mon, 17 Dec 2018 23:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4E7DFE00EA for ; Mon, 17 Dec 2018 23:23:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0813723FC5 for ; Mon, 17 Dec 2018 23:23:00 +0000 (UTC) Date: Mon, 17 Dec 2018 23:23:00 +0000 (UTC) From: "Ilya Maykov (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (ZOOKEEPER-3219) Fix flaky FileChangeWatcherTest MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ilya Maykov created ZOOKEEPER-3219: -------------------------------------- Summary: Fix flaky FileChangeWatcherTest Key: ZOOKEEPER-3219 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3219 Project: ZooKeeper Issue Type: Improvement Affects Versions: 3.6.0, 3.5.5 Reporter: Ilya Maykov Assignee: Ilya Maykov A test I committed recently is flaky. Here is an example of failed test out= put from jenkins: =C2=A0 {code:java} 2018-12-17 21:52:53,824 [myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvok= eMethod@77] - RUNNING TEST METHOD testCallbackErrorDoesNotCrashWatcherThrea= d 2018-12-17 21:52:53,826 [myid:] - INFO [FileChangeWatcher:FileChangeWatch= er$WatcherThread@193] - FileChangeWatcher thread started 2018-12-17 21:52:5= 4,830 [myid:] - INFO [main:FileChangeWatcherTest@237] - Modifying file 2018= -12-17 21:52:54,834 [myid:] - INFO [FileChangeWatcher:FileChangeWatcherTest= @222] - Got an update: ENTRY_CREATE zk_test_5141143184635472109 2018-12-17 = 21:52:54,835 [myid:] - ERROR [FileChangeWatcher:FileChangeWatcher$WatcherTh= read@238] - Error from callback java.lang.RuntimeException: This error shou= ld not crash the watcher thread at org.apache.zookeeper.common.FileChangeWa= tcherTest.lambda$testCallbackErrorDoesNotCrashWatcherThread$4(FileChangeWat= cherTest.java:226) at org.apache.zookeeper.common.FileChangeWatcher$Watcher= Thread.runLoop(FileChangeWatcher.java:236) at org.apache.zookeeper.common.F= ileChangeWatcher$WatcherThread.run(FileChangeWatcher.java:205) 2018-12-17 2= 1:52:54,837 [myid:] - INFO [main:FileChangeWatcherTest@244] - Modifying fil= e again 2018-12-17 21:52:54,837 [myid:] - INFO [FileChangeWatcher:FileChang= eWatcherTest@222] - Got an update: ENTRY_MODIFY zk_test_5141143184635472109= 2018-12-17 21:52:54,838 [myid:] - INFO [FileChangeWatcher:FileChangeWatche= rTest@222] - Got an update: ENTRY_MODIFY zk_test_5141143184635472109 2018-1= 2-17 21:52:54,839 [myid:] - INFO [FileChangeWatcher:FileChangeWatcher$Watch= erThread@215] - FileChangeWatcher thread finished 2018-12-17 21:52:54,839 [= myid:] - INFO [main:JUnit4ZKTestRunner$LoggedInvokeMethod@98] - TEST METHOD= FAILED testCallbackErrorDoesNotCrashWatcherThread java.lang.AssertionError= : expected:<2> but was:<3> at org.junit.Assert.fail(Assert.java:88) at org.= junit.Assert.failNotEquals(Assert.java:834) at org.junit.Assert.assertEqual= s(Assert.java:645) at org.junit.Assert.assertEquals(Assert.java:631) at org= .apache.zookeeper.common.FileChangeWatcherTest.testCallbackErrorDoesNotCras= hWatcherThread(FileChangeWatcherTest.java:250) at sun.reflect.NativeMethodA= ccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.= invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAcc= essorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect= .Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$= 1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.= model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runne= rs.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) at org.= junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:1= 7) at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(J= Unit4ZKTestRunner.java:79) at org.junit.rules.TestWatchman$1.evaluate(TestW= atchman.java:53) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.jav= a:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4Clas= sRunner.java:78) at org.junit.runners.BlockJUnit4ClassRunner.runChild(Block= JUnit4ClassRunner.java:57) at org.junit.runners.ParentRunner$3.run(ParentRu= nner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.ja= va:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)= at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.= junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.i= nternal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.j= unit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at o= rg.junit.runners.ParentRunner.run(ParentRunner.java:363) at junit.framework= .JUnit4TestAdapter.run(JUnit4TestAdapter.java:38) at org.apache.tools.ant.t= askdefs.optional.junit.JUnitTestRunner.run(JUnitTestRunner.java:535) at org= .apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.launch(JUnitTestR= unner.java:1182) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestR= unner.main(JUnitTestRunner.java:1033) 2018-12-17 21:52:54,847 [myid:] - INF= O [main:ZKTestCase$1@74] - FAILED testCallbackErrorDoesNotCrashWatcherThrea= d java.lang.AssertionError: expected:<2> but was:<3> at org.junit.Assert.fa= il(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at or= g.junit.Assert.assertEquals(Assert.java:645) at org.junit.Assert.assertEqua= ls(Assert.java:631) at org.apache.zookeeper.common.FileChangeWatcherTest.te= stCallbackErrorDoesNotCrashWatcherThread(FileChangeWatcherTest.java:250) at= sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect= .NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.r= eflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav= a:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runn= ers.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at o= rg.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.j= ava:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framew= orkMethod.java:47) at org.junit.internal.runners.statements.InvokeMethod.ev= aluate(InvokeMethod.java:17) at org.apache.zookeeper.JUnit4ZKTestRunner$Log= gedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:79) at org.junit.rules.Tes= tWatchman$1.evaluate(TestWatchman.java:53) at org.junit.runners.ParentRunne= r.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunne= r.runChild(BlockJUnit4ClassRunner.java:78) at org.junit.runners.BlockJUnit4= ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) at org.junit.runners.P= arentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$= 1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChild= ren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(Par= entRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunne= r.java:268) at org.junit.internal.runners.statements.RunBefores.evaluate(Ru= nBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evalua= te(RunAfters.java:27) at org.junit.runners.ParentRunner.run(ParentRunner.ja= va:363) at junit.framework.JUnit4TestAdapter.run(JUnit4TestAdapter.java:38)= at org.apache.tools.ant.taskdefs.optional.junit.JUnitTestRunner.run(JUnitT= estRunner.java:535) at org.apache.tools.ant.taskdefs.optional.junit.JUnitTe= stRunner.launch(JUnitTestRunner.java:1182) at org.apache.tools.ant.taskdefs= .optional.junit.JUnitTestRunner.main(JUnitTestRunner.java:1033) 2018-12-17 = 21:52:54,848 [myid:] - INFO [main:ZKTestCase$1@64] - FINISHED testCallbackE= rrorDoesNotCrashWatcherThread{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)