From dev-return-76830-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Dec 26 19:53:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB762180674 for ; Wed, 26 Dec 2018 19:53:04 +0100 (CET) Received: (qmail 18514 invoked by uid 500); 26 Dec 2018 18:53:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 18503 invoked by uid 99); 26 Dec 2018 18:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Dec 2018 18:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 44ACB180CFF for ; Wed, 26 Dec 2018 18:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Lh9buETnqpsC for ; Wed, 26 Dec 2018 18:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5D59F610FE for ; Wed, 26 Dec 2018 18:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 89510E111B for ; Wed, 26 Dec 2018 18:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 27D8B25358 for ; Wed, 26 Dec 2018 18:53:00 +0000 (UTC) Date: Wed, 26 Dec 2018 18:53:00 +0000 (UTC) From: "Brian Nixon (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3197) Improve documentation in ZooKeeperServer.superSecret MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3197?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 16729138#comment-16729138 ]=20 Brian Nixon commented on ZOOKEEPER-3197: ---------------------------------------- Password is probably the wrong term for this variable (though it does sugge= st some potential future work). It's more of a checksum that's used in reco= nnection, carries no security weight, and is treated internally as if it ca= rries no security weight. =C2=A0 [~breed] might be the only one left who knows the full story (it's telling = that the secret decodes to "Ben is Cool"). =C2=A0 > Improve documentation in ZooKeeperServer.superSecret > ---------------------------------------------------- > > Key: ZOOKEEPER-3197 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3197 > Project: ZooKeeper > Issue Type: Task > Reporter: Colm O hEigeartaigh > Priority: Trivial > > A security scan flagged the use of a hard-coded secret (ZooKeeperServer.s= uperSecret) in conjunction with a java Random instance to generate a passwo= rd: > byte[] generatePasswd(long id) > { =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 Random r = =3D new Random(id ^ superSecret); =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 =C2=A0=C2=A0=C2=A0 byte p[] =3D new byte[16]; =C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 r.nextBytes(p); =C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 return p; =C2=A0=C2=A0=C2=A0 } > superSecret has the following javadoc: > =C2=A0/** > =C2=A0=C2=A0 * This is the secret that we use to generate passwords, for= the moment it > =C2=A0=C2=A0 * is more of a sanity check. > =C2=A0=C2=A0 */ > It is unclear from this comment and looking at the code why it is not a s= ecurity risk. It would be good to update the javadoc along the lines of "Us= ing a hard-coded secret with Random to generate a password is not a securit= y risk because the resulting passwords are used for X, Y, Z and not for aut= hentication etc" or something would be very helpful for anyone else looking= at the code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)