From dev-return-76727-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Dec 19 14:50:53 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4CBB1180670 for ; Wed, 19 Dec 2018 14:50:52 +0100 (CET) Received: (qmail 38845 invoked by uid 500); 19 Dec 2018 13:50:51 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 38825 invoked by uid 99); 19 Dec 2018 13:50:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Dec 2018 13:50:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id DB2AE180D3F for ; Wed, 19 Dec 2018 13:50:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.799 X-Spam-Level: * X-Spam-Status: No, score=1.799 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id LDSonhkbTZLT for ; Wed, 19 Dec 2018 13:50:46 +0000 (UTC) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1DFA15F577 for ; Wed, 19 Dec 2018 13:50:45 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id s66so2022677ybc.4 for ; Wed, 19 Dec 2018 05:50:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=BkZVneuJhEa6OOv35X0fBKh6OXvGaFuIuLNJqYRIJAk=; b=WICEdrU8CUBU/4BD9U+/Xf7lHyPznEqtf8QWHqj3rRXZC8Zhd7TZ3Ngaed/iNXTojm uTrtD3W18h7zfUA0x/Ly6eQvRVB9GgKsZf7OGzkYY0ZvDYwfNORiDOjq9oxyEqgMMIfK BAwefjdX9H2X2i7WsjRoa3VdtgM/LiQkbaCSqqvUWvtOsZrSeAHyq2C/t08N7DMkdqJQ B25Y+umaN95NKGLWHz2+GyPbcXgZXbQdYhKkRNwhEt+oAEs4wJzvhezwMZ06l45QYaF7 V133IyFLlMr5Oii8aCSKqwujEMZWxYVx7lZGsHQBgVQ4uYlO+7wg5Ksiqjc1jG6rWT2X dRBQ== X-Gm-Message-State: AA+aEWbXvD8+3L43nHmCFAoytJH6E1eSZpGSNa91lIRppFmGXJCL6kIh zVrmhhwm7Vt59mpriu+3Cj6sGzkIwKxFdh59Awsv/Z0FKqA= X-Google-Smtp-Source: AFSGD/VXX7KOjJPff7DKm3Pm6IvFRQleqQTKhPXdPAGXr3xIg3DSImTrNiDD0SRp3Hk4SxwhobmK2KGPeN2YHSMgdw0= X-Received: by 2002:a25:c642:: with SMTP id k63mr20926739ybf.401.1545227443424; Wed, 19 Dec 2018 05:50:43 -0800 (PST) MIME-Version: 1.0 References: <490E1A21-0DD5-4728-803C-5AC35C2DEFDE@fb.com> <1efce6c9-5167-d9d2-75e0-483e92f26983@apache.org> <31087A53-95A0-486C-8D24-36F8B5B691B6@apache.org> In-Reply-To: From: Tamas Penzes Date: Wed, 19 Dec 2018 14:50:31 +0100 Message-ID: Subject: Re: ZooKeeper 3.5 blocker issues To: dev@zookeeper.apache.org Content-Type: multipart/alternative; boundary="000000000000dcf458057d604cfb" --000000000000dcf458057d604cfb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi All, For assembly task I would promote the way how HBase works. They create a pure source and a bin tarball separately. Please see how they create a release here: https://github.com/apache/hbase/blob/master/dev-support/make_rc.sh We could probably use the well known "copy+paste technology" to have it within ZooKeeper the same way. ;-) Regards, Tamaas On Wed, Dec 19, 2018 at 2:28 PM Enrico Olivelli wrote= : > Great work Norbert > I you want I can help,especially for rat, findbugs (need to switch to > spotbugs anyway) and OWASP stuff (recently I started using Maven > Plugin in other projects) > But I am not sure how can I help you concretely if we do not commit your > work. > We could commit the work as it is now, leaving "ant" as official build > method, but having the poms committed will ease collaboration. > > We will also have to work on CI jobs, I can help on that part as well > > Enrico > > Il giorno mer 19 dic 2018 alle ore 12:26 Norbert Kalmar > ha scritto: > > > > Hi everyone, > > > > Some update on the maven migration: I had a few bumps here and there > (just > > looking at the latest patch Andor linked - > > https://github.com/apache/zookeeper/pull/708 - you can see on the > commits). > > Current state is that the build works, tests run, but reports like > > findbugs, clover etc. are not yet implemented. Maven has plugins for th= em > > usually, but it's not always trivial, especially with the C client. The > > assembly is also left to be done, but it should be fairly easy to do a > > similar tarball then ant does (although this will be also an interestin= g > > task, as ant does some strange things, like duplicated sources of most > > contrib projects). > > > > I had a seperate jira to do the recipes and contrib maven build. I do n= ot > > have open PR for it, but recipes is done and I am now working on the > > contrib projects. Most of them is manually build and never gets called > from > > the main build.xml. I will not integrate these either to the maven buil= d. > > The reason is that there are plans to remove some of them from ZK repo > > anyway. The other reason is that for starters, we want to replicate the > ant > > build as closely as possible, without doing any nasty workarounds in > maven > > to achieve that. And from there, we can improve, use maven's advantages > to > > shape the build of ZooKeeper. Once it is stable and proven to have all > the > > functionality required for build and release. > > > > Right now, I am trying to stabilize the build as much as possible. Ando= r > > also fixed some flaky C tests that for some strange reasons, become > > extremely flaky with the maven build: > > https://github.com/apache/zookeeper/pull/740 > > > > Regards, > > Norbert > > > > On Tue, Dec 18, 2018 at 9:52 AM Andor Molnar > > > wrote: > > > > > Sure, good point. Let's put it on the list. > > > > > > Andor > > > > > > > > > On Tue, Dec 18, 2018 at 12:17 AM Patrick Hunt > wrote: > > > > > > > Are folks OK to wait on that OWASP issue I documented over the > weekend? > > > > afaict we are not affected but it would be good to get another pair > of > > > eyes > > > > on it. > > > > > > > > Patrick > > > > > > > > On Mon, Dec 17, 2018 at 2:55 PM Andor Moln=C3=A1r > wrote: > > > > > > > > > Hi team, > > > > > > > > > > > > > > > I'm proudly announce that thanks to the joint effort from the > > > community, > > > > > the 3.5 blockers list has become empty: > > > > > > > > > > "project =3D ZooKeeper AND resolution =3D Unresolved AND fixVersi= on =3D > 3.5.5 > > > > > AND priority in (blocker, critical) ORDER BY priority DESC, key > ASC" > > > > > > > > > > > > > > > Well... almost. All the blocker issues have gone, but we still > have the > > > > > Maven migration to complete before the stable release. If you hav= e > some > > > > > free cycles, please join us testing the Maven build on this PR: > > > > > > > > > > https://github.com/apache/zookeeper/pull/708 > > > > > > > > > > I hope we can merge it pretty soon. > > > > > > > > > > > > > > > In terms of the builds, the weather at 3.5 branch is quite sunny > > > > nowadays: > > > > > > > > > > https://builds.apache.org/view/S-Z/view/ZooKeeper/ > > > > > > > > > > The Java 11 build is still having some difficulties, which > hopefully I > > > > > can address before the holidays: > > > > > > > > > > https://issues.apache.org/jira/browse/ZOOKEEPER-3204 > > > > > > > > > > > > > > > If you happen to know about something which is important from 3.5= 's > > > > > perspective and missing from the above, please don't hesitate to > share. > > > > > > > > > > > > > > > Happy ZooKeeping! > > > > > > > > > > Andor > > > > > > > > > > > > > > > > > > > > On 11/2/18 21:12, Fangmin Lv wrote: > > > > > > Andor, > > > > > > > > > > > > Here is the PR to port ZK-3104 from master to 3.4: > > > > > > https://github.com/apache/zookeeper/pull/685. > > > > > > > > > > > > Fangmin > > > > > > > > > > > > On Fri, Nov 2, 2018 at 11:46 AM Fangmin Lv > > > > wrote: > > > > > > > > > > > >> Hi Andor, > > > > > >> > > > > > >> Is anyone working on ZK-2778? I can pick it up if there is no > one > > > > > working > > > > > >> on it yet. > > > > > >> > > > > > >> I'll open a 3.5 PR for ZK-3104 today. > > > > > >> > > > > > >> Fangmin > > > > > >> > > > > > >> On Fri, Oct 26, 2018 at 3:33 AM Andor Molnar > > > > wrote: > > > > > >> > > > > > >>> Hi folks, > > > > > >>> > > > > > >>> You=E2=80=99ve probably realised lots of update emails coming= from > Jira. > > > > Please > > > > > >>> be aware that we=E2=80=99ve updated a bunch of open blocker/c= ritical > 3.5 > > > > > tickets to > > > > > >>> reflect to what we discussed in this email. > > > > > >>> > > > > > >>> If you open up the following jira filter: > > > > > >>> > > > > > >>> project =3D ZooKeeper and resolution =3D Unresolved and fixVe= rsion > =3D > > > > 3.5.5 > > > > > >>> AND priority in (blocker, critical) ORDER BY priority DESC, > key ASC > > > > > >>> > > > > > >>> You=E2=80=99ll see the most up-to-date list of tickets which = need to be > > > > > addressed > > > > > >>> before the stable 3.5 release. > > > > > >>> > > > > > >>> Thank you for your efforts to get this done. > > > > > >>> > > > > > >>> Fangmin, ZK-3104 is waiting for backport, but ticket has > already > > > been > > > > > >>> resolved. Have you created a separate ticket for the backport > or > > > > shall > > > > > I > > > > > >>> just reopen it with the right fix versions? > > > > > >>> > > > > > >>> Thanks, > > > > > >>> Andor > > > > > >>> > > > > > >>> > > > > > >>> > > > > > >>>> On 2018. Oct 8., at 12:34, Andor Molnar > wrote: > > > > > >>>> > > > > > >>>> Hi, > > > > > >>>> > > > > > >>>> Let me summarize and give a quick update on the outstanding > issues > > > > for > > > > > >>> 3.5 GA: > > > > > >>>> - ZOOKEEPER-1818 (Fix don't care for trunk) > > > > > >>>> - ZOOKEEPER-2778 (Potential server deadlock between follower > sync > > > > with > > > > > >>> leader and follower receiving external connection requests.) > > > > > >>>> - ZOOKEEPER-3021 Migrate project structure to Maven (ongoing= ) > > > > > >>>> - ZOOKEEPER-925 Docs generation to Maven > > > > > >>>> - ZOOKEEPER-3104 (waiting for backport) > > > > > >>>> - ZOOKEEPER-3125 (waiting for backport PR #647) > > > > > >>>> > > > > > >>>> The 2 Maven related tickets are no-brainers as well as the > > > > backports. > > > > > >>> ZK-2778 has been picked up by Maoling (thanks!) as far as I c= an > > > see, > > > > > >>> ZK-1818 is the only one waiting for a volunteer. > > > > > >>>> Please correct me if I=E2=80=99ve missed something. > > > > > >>>> > > > > > >>>> Regards, > > > > > >>>> Andor > > > > > >>>> > > > > > >>>> > > > > > >>>> > > > > > >>>> > > > > > >>>>> On 2018. Sep 28., at 18:32, Tamas Penzes > > > > > > > > > > > > > > >>> wrote: > > > > > >>>>> Hi All, > > > > > >>>>> > > > > > >>>>> I would add ZOOKEEPER-3021 > > > > > >>>>> > Migrate > > > > > project > > > > > >>>>> structure to Maven build as a blocker too. Since the > migration > > > has > > > > > >>> started > > > > > >>>>> it would be good to finish before releasing ZK 3.5.x GA. > > > > > >>>>> > > > > > >>>>> ZOOKEEPER-925 < > > > https://issues.apache.org/jira/browse/ZOOKEEPER-925 > > > > > > > > > > >>> replace > > > > > >>>>> our forrest site and documentation generation might also be= a > > > good > > > > > >>> idea, > > > > > >>>>> since then we could deliver the new MarkDown based > documentation. > > > > > >>>>> > > > > > >>>>> Regards, Tamaas > > > > > >>>>> > > > > > >>>>> On Fri, Sep 14, 2018 at 10:09 AM Fangmin Lv < > lvfangmin@gmail.com > > > > > > > > > >>> wrote: > > > > > >>>>>> Oh, sorry for the confusion, I should provide more context= . > > > > > >>>>>> > > > > > >>>>>> Leader will use on disk txn sync with followers to if the > peer > > > > zxid > > > > > >>> is not > > > > > >>>>>> in it's in memory commit logs, the code is here: Leader on > disk > > > > txn > > > > > >>> sync > > > > > >>>>>> < > > > > > >>>>>> > > > > > >>> > > > > > > > > > > > > > https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/= zookeeper/server/quorum/LearnerHandler.java#L774 > > > > > >>>>>>> . > > > > > >>>>>> There is bug that potentially there will be gap in the txn > > > files, > > > > > like > > > > > >>>>>> after snap sync, etc, so it's possible the peer will miss > txns > > > due > > > > > to > > > > > >>> this. > > > > > >>>>>> The option to disable it is snapshotSizeFactor > > > > > >>>>>> < > > > > > >>>>>> > > > > > >>> > > > > > > > > > > > > > https://github.com/apache/zookeeper/blob/master/src/java/main/org/apache/= zookeeper/server/ZKDatabase.java#L81 > > > > > >>>>>>> , > > > > > >>>>>> set it to -1 will disable this feature. On 3.5, it's bette= r > to > > > > have > > > > > a > > > > > >>> PR to > > > > > >>>>>> set this to -1 by default. It might have more SNAP sync, b= ut > > > from > > > > > our > > > > > >>> prod > > > > > >>>>>> it doesn't seem to be a big problem to me. > > > > > >>>>>> > > > > > >>>>>> I can send out the diff to disable it by default on 3.5 if > you > > > > guys > > > > > >>> think > > > > > >>>>>> this is the right way to do. > > > > > >>>>>> > > > > > >>>>>> Thanks, > > > > > >>>>>> Fangmin > > > > > >>>>>> > > > > > >>>>>> On Thu, Sep 13, 2018 at 1:58 AM Andor Molnar < > andor@apache.org> > > > > > >>> wrote: > > > > > >>>>>>> What=E2=80=99s needed to turn it off? > > > > > >>>>>>> Do we need a PR or it=E2=80=99s just a config option? > > > > > >>>>>>> Shall we implement a feature switch for that and turn it > off by > > > > > >>> default? > > > > > >>>>>>> Sorry I don=E2=80=99t have too much insight on disk txn s= ync. > > > > > >>>>>>> > > > > > >>>>>>> Andor > > > > > >>>>>>> > > > > > >>>>>>> > > > > > >>>>>>> > > > > > >>>>>>>> On 2018. Sep 13., at 9:16, Fangmin Lv < > lvfangmin@gmail.com> > > > > > wrote: > > > > > >>>>>>>> > > > > > >>>>>>>> And to be clear, ZOOKEEPER-2418 is actually just one cas= e > of > > > > > >>>>>>> inconsistency > > > > > >>>>>>>> which could caused by on disk txn sync, as I mentioned i= n > a > > > > newer > > > > > >>> JIRA > > > > > >>>>>>>> ZOOKEEPER-2846 < > > > > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2846>, > > > > > >>>>>>> the > > > > > >>>>>>>> snap sync or txn sync could also leave txns gap in the t= xn > > > file, > > > > > >>> which > > > > > >>>>>>> is a > > > > > >>>>>>>> more common case could trigger this issue. > > > > > >>>>>>>> > > > > > >>>>>>>> I would suggest to turn off the on disk txn sync by > default > > > for > > > > > now > > > > > >>> to > > > > > >>>>>>>> avoid this issue, after we finished ZOOKEEPER-3114, we > can use > > > > > that > > > > > >>> to > > > > > >>>>>>>> validate the on disk txns during syncing. > > > > > >>>>>>>> > > > > > >>>>>>>> Thanks, > > > > > >>>>>>>> Fangmin > > > > > >>>>>>>> > > > > > >>>>>>>> On Wed, Sep 12, 2018 at 9:55 AM Fangmin Lv < > > > lvfangmin@gmail.com > > > > > > > > > > >>>>>> wrote: > > > > > >>>>>>>>> Andor, > > > > > >>>>>>>>> > > > > > >>>>>>>>> ZOOKEEPER-3114 is about adding real time digest checkin= g > to > > > > help > > > > > >>>>>>> detecting > > > > > >>>>>>>>> inconsistency, it's a new feature with amounts of code > > > change. > > > > > I'll > > > > > >>>>>>> start > > > > > >>>>>>>>> upstream it part by part, but I don't expect it's being > > > merged > > > > in > > > > > >>> the > > > > > >>>>>>> next > > > > > >>>>>>>>> few weeks. So yes, it's a nice to have, but definitely > not a > > > > > block > > > > > >>> for > > > > > >>>>>>> 3.5. > > > > > >>>>>>>>> Thanks, > > > > > >>>>>>>>> Fangmin > > > > > >>>>>>>>> > > > > > >>>>>>>>> On Wed, Sep 12, 2018 at 2:55 AM Andor Molnar < > > > andor@apache.org > > > > > > > > > > >>>>>> wrote: > > > > > >>>>>>>>>> Fangmin, > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> Sorry, I just noticed that you want to include the > > > consistency > > > > > >>> fixes > > > > > >>>>>> in > > > > > >>>>>>>>>> the stable version which is fine. Let=E2=80=99s finish= the > backports > > > > and > > > > > >>>>>> we=E2=80=99ll > > > > > >>>>>>> be > > > > > >>>>>>>>>> done with them. > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> ZOOKEEPER-3114 is essentially a new feature, I wouldn= =E2=80=99t > > > block > > > > > 3.5 > > > > > >>>>>> with > > > > > >>>>>>>>>> that. What do you think? > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> Andor > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> > > > > > >>>>>>>>>> > > > > > >>>>>>>>>>> On 2018. Sep 12., at 11:52, Andor Molnar < > andor@apache.org > > > > > > > > > >>> wrote: > > > > > >>>>>>>>>>> Cool, thanks for the clarification. > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> The updated list is as follows: > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> - ZOOKEEPER-236 (SSL/TLS support for Atomic Broadcast > > > > protocol) > > > > > >>>>>>>>>>> - ZOOKEEPER-1818 (Fix don't care for trunk) > > > > > >>>>>>>>>>> - ZOOKEEPER-2778 (Potential server deadlock between > > > follower > > > > > sync > > > > > >>>>>> with > > > > > >>>>>>>>>> leader and follower receiving external connection > requests.) > > > > > >>>>>>>>>>> The following are not critical and no blockers for th= e > > > stable > > > > > >>>>>> release: > > > > > >>>>>>>>>>> Waiting for to be ported to 3.5: > > > > > >>>>>>>>>>> - ZOOKEEPER-3104 > > > > > >>>>>>>>>>> - ZOOKEEPER-3125 > > > > > >>>>>>>>>>> - ZOOKEEPER-3127 > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> New feature: > > > > > >>>>>>>>>>> - ZOOKEEPER-3114 (fixes ZOOKEEPER-2184 too) > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> Regards, > > > > > >>>>>>>>>>> Andor > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>> > > > > > >>>>>>>>>>>> On 2018. Sep 12., at 0:42, Fangmin Lv < > > > lvfangmin@gmail.com> > > > > > >>> wrote: > > > > > >>>>>>>>>>>> Hi Andor, > > > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> That's the on disk txn feature, which was disabled > > > > internally > > > > > >>> after > > > > > >>>>>>> we > > > > > >>>>>>>>>>>> found the potentially inconsistent issue. The only > > > solution > > > > we > > > > > >>> have > > > > > >>>>>>>>>> for now > > > > > >>>>>>>>>>>> is waiting for the new digest checking feature I > mentioned > > > > in > > > > > >>>>>>>>>>>> ZOOKEEPER-3114. > > > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> I think there are some other critical consistent > issues we > > > > > just > > > > > >>>>>> fixed > > > > > >>>>>>>>>> on > > > > > >>>>>>>>>>>> master recently: ZOOKEEPER-3104, ZOOKEEPER-3125, > > > > > >>> ZOOKEEPER-3127, I > > > > > >>>>>>>>>> think we > > > > > >>>>>>>>>>>> should include that in the official 3.5 release as > well. > > > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> Thanks, > > > > > >>>>>>>>>>>> Fangmin > > > > > >>>>>>>>>>>> > > > > > >>>>>>>>>>>> On Tue, Sep 11, 2018 at 11:58 AM Andor Moln=C3=A1r < > > > > > andor@apache.org > > > > > >>>>>>>>>> wrote: > > > > > >>>>>>>>>>>>> Hi Jeelani, > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> Thanks for letting me know. I'm happy to remove it > from > > > the > > > > > >>> list > > > > > >>>>>> to > > > > > >>>>>>>>>> get > > > > > >>>>>>>>>>>>> closer to a stable release. :) > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> What's the feature which can be disabled to avoid > data > > > > > >>>>>>> inconsistency? > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> Andor > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> On 09/10/2018 11:33 PM, Mohamed Jeelani wrote: > > > > > >>>>>>>>>>>>>> Thanks Andor for compiling this. Should we be > ignoring > > > > > >>>>>>>>>> ZOOKEEPER-2418 as > > > > > >>>>>>>>>>>>> well? This exists in 3.4 as well and the feature ca= n > be > > > > > >>> disabled. > > > > > >>>>>> We > > > > > >>>>>>>>>> are > > > > > >>>>>>>>>>>>> working on a longer term fix for it in 3.6. > > > > > >>>>>>>>>>>>>> Regards, > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> Jeelani > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> =EF=BB=BFOn 9/10/18, 5:19 AM, "Andor Molnar" > > > > > >>> > > > > >>>>>>>>>> wrote: > > > > > >>>>>>>>>>>>>> Fine. > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> I'm happy to ignore 1549, 2846 and 2930. Still we > have > > > the > > > > > >>> list > > > > > >>>>>>> of: > > > > > >>>>>>>>>>>>>> - ZOOKEEPER-236 (SSL/TLS support for Atomic > Broadcast > > > > > >>> protocol) > > > > > >>>>>>>>>>>>>> - ZOOKEEPER-1818 (Fix don't care for trunk) > > > > > >>>>>>>>>>>>>> - ZOOKEEPER-2418 (txnlog diff sync can skip sendin= g > some > > > > > >>>>>>>>>>>>> transactions to > > > > > >>>>>>>>>>>>>> followers) > > > > > >>>>>>>>>>>>>> - ZOOKEEPER-2778 (Potential server deadlock betwee= n > > > > follower > > > > > >>>>>> sync > > > > > >>>>>>>>>>>>> with > > > > > >>>>>>>>>>>>>> leader and follower receiving external connection > > > > requests.) > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> SSL (ZK-236) is a feature which essential for the > 3.5 > > > > > release, > > > > > >>>>>>>>>> hence > > > > > >>>>>>>>>>>>> I > > > > > >>>>>>>>>>>>>> wouldn't leave it out or postpone it for the next > stable > > > > > >>>>>> release. > > > > > >>>>>>>>>> PR > > > > > >>>>>>>>>>>>> has > > > > > >>>>>>>>>>>>>> been out for a long time, get on reviewing please. > > > > > >>>>>>>>>>>>>> The rest are also long outstanding issues which ha= ve > > > been > > > > > >>> found > > > > > >>>>>> in > > > > > >>>>>>>>>>>>> the 3.5 > > > > > >>>>>>>>>>>>>> branch. > > > > > >>>>>>>>>>>>>> ZK-1818 is something which was found in 3.4 and > fixed in > > > > > 3.4, > > > > > >>>>>> but > > > > > >>>>>>>>>>>>> never has > > > > > >>>>>>>>>>>>>> been fixed in 3.5. Quite a serious issue if still > > > present. > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> I think we should at least run some manual testing > and > > > see > > > > > if > > > > > >>> we > > > > > >>>>>>>>>>>>> could > > > > > >>>>>>>>>>>>>> repro any of these issues before going ahead with = a > > > stable > > > > > >>>>>>> release. > > > > > >>>>>>>>>>>>>> Regards, > > > > > >>>>>>>>>>>>>> Andor > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> On Fri, Sep 7, 2018 at 3:24 AM, Michael Han < > > > > > hanm@apache.org> > > > > > >>>>>>>>>> wrote: > > > > > >>>>>>>>>>>>>>> I haven't went through the entire list, but looks > like > > > > lots > > > > > >>> of > > > > > >>>>>> the > > > > > >>>>>>>>>>>>> JIRA > > > > > >>>>>>>>>>>>>>> issues listed in this thread, such as > ZOOKEEPER-1549, > > > > 2846, > > > > > >>> also > > > > > >>>>>>>>>>>>> affects > > > > > >>>>>>>>>>>>>>> 3.4 releases. Should we scope these issues out? > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> I think historically the single outstanding > blocking > > > > issue > > > > > >>> for a > > > > > >>>>>>>>>>>>> stable 3.5 > > > > > >>>>>>>>>>>>>>> release is the reconfig feature and security > concerns > > > > > around > > > > > >>> it > > > > > >>>>>>>>>>>>> (somehow > > > > > >>>>>>>>>>>>>>> addressed in ZOOKEEPER-2014), and the alpha and > beta > > > > > releases > > > > > >>>>>> were > > > > > >>>>>>>>>>>>> created > > > > > >>>>>>>>>>>>>>> to stabilize that feature. > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> > > > > > >>> > > > > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttp-3A__zookeeper-2Duser.57= 8899.n2.nabble.com_Zookeeper-2Dwith-2D&d=3DDwIBaQ&c=3D5VD0RTtNlTh3ycd41b3MU= w&r=3DVl4oKanLQehvaulUvoKg8A&m=3Dwqlhnot9c-pQLdkGkccSGNpELUNUnB-wy_h0iA3PRq= I&s=3D_tGtL3nMWtuPrXKXDx27AIWOzyyT7W-CjIVLDFZwT0E&e=3D > > > > > >>>>>>>>>>>>>>> SSL-release-date-tt7581744.html > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> So it looks like we are in good shape to release. > > > > Something > > > > > >>>>>> might > > > > > >>>>>>>>>>>>> worth > > > > > >>>>>>>>>>>>>>> doing to claim the quality of 3.5 is on par with > 3.4 > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> * Run Jepsen on 3.5 - 3.4 passed the test for the > > > record > > > > > >>>>>>>>>>>>>>> > > > > > >>> > > > > > > > > > > > > > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__aphyr.com_posts_29= 1-2Djepsen-2Dzookeeper&d=3DDwIBaQ&c=3D5VD0RTtNlTh3ycd41b3MUw&r=3DVl4oKanLQe= hvaulUvoKg8A&m=3Dwqlhnot9c-pQLdkGkccSGNpELUNUnB-wy_h0iA3PRqI&s=3DVjORkX5s7h= rJyl8mW9Q4cfeSWF4qfTdyRjcuAiBt0y4&e=3D > > > > > >>>>>>>>>>>>>>> * Fix all flaky tests on 3.5 - 3.4 has little or = no > > > flaky > > > > > >>> tests > > > > > >>>>>> at > > > > > >>>>>>>>>>>>> all. > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> On Tue, Sep 4, 2018 at 1:48 AM, Andor Molnar > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>> wrote: > > > > > >>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>>> Thanks Maoling! That would be huge help, I > appreciate > > > > it. > > > > > >>>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>>>> Andor > > > > > >>>>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>>> > > > > > >>>>>>>>>>>>> > > > > > >>>>>>>>>> > > > > > >>>>>>> > > > > > >>> > > > > > > > > > > > > > --000000000000dcf458057d604cfb--