From dev-return-76787-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Dec 20 17:20:09 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9023A180648 for ; Thu, 20 Dec 2018 17:20:08 +0100 (CET) Received: (qmail 70372 invoked by uid 500); 20 Dec 2018 16:20:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 69766 invoked by uid 99); 20 Dec 2018 16:20:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Dec 2018 16:20:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 735C11817D6 for ; Thu, 20 Dec 2018 16:20:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.201 X-Spam-Level: X-Spam-Status: No, score=-0.201 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TbQ8lbZdchuV for ; Thu, 20 Dec 2018 16:20:05 +0000 (UTC) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C6E495FB39 for ; Thu, 20 Dec 2018 16:20:04 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id b11so2659480wmj.1 for ; Thu, 20 Dec 2018 08:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=A153nbiyt97lNNXFfQZjOw1tqdxMTaPa383SRChOuRM=; b=e172lu7Nduijj/sa1Npa36Y5GyFzlQbIioQ+0cZcX8UXQRUfSh+pUkypa9g73qkZXN Kq5D3C9I9P88hYlhSJwp/PY/ovbYwg3ZOF9uRNuEkt5Ja8g7AMxcuXnAySDIBAh2uBHo qZsg58oVSO58IhwMYkNjOFzLUODGm5HhsdqH44E4jVBUWOGXCMAaE2S2rgqHiqRfCu9D fF6MAKAvsc80X29zNv5z8/tDeqiMnUn6FEKQgeayNrVWxAzHc+l6lWWQnE1nCY/4sTjY egB92T75WYj35rKoIUJ+5rNErdkK1aL7GtjUUIUVkV7LmXCCHtYVxphEDG4t7Gk6f7OX yMOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=A153nbiyt97lNNXFfQZjOw1tqdxMTaPa383SRChOuRM=; b=Uhn3VtSRTRsci2dRRg7kJ3sDG2EfFsfmvIttdQxWcNiJa2pp/UAdjLUEdkKacBpcE5 G+DwczNMYDPgh0vWTVwnJ0yYUWjG4XDKlYyYl3StU8O7AtCPhMi4UEhGpiI4BJ1/PFCu 7ca60+bHxSpXCp607KrcgU0a56vHaFV8xiCzGjnz9GH43wNDkSE28MNjnf1ia/ZIxJv5 +u31H1p4ljJmnX2CprqpSUJZA/LSU87oHItIccpoJgYFSo8qPbmGgw303us5fCsR0hf0 ux1JAjcESg2dusOR3QwVjmxpbd/Zv9x+9Y2ejzkNB3dEWvuk8euLEcIaDX3MuHiBFF8j 4gYQ== X-Gm-Message-State: AA+aEWaL8ywD+uhRuAbIqXg91NE/V5RlCNvtbekjM4ZWA+wcKXm22pjG 4jakaOXA3jI6gs+k+I3fyxklbyQr7MNyTQYoDhyLy2UT X-Google-Smtp-Source: AFSGD/WFjebdKHShFYbFp9BJbQZjN44Q9DgAmbPAjePBZAbQoOHHqNKwLLA6jdOESUgFqNCVGV+ziLAfh4VAgAQmnRU= X-Received: by 2002:a1c:5656:: with SMTP id k83mr12224442wmb.125.1545322797836; Thu, 20 Dec 2018 08:19:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Enrico Olivelli Date: Thu, 20 Dec 2018 17:19:46 +0100 Message-ID: Subject: Re: Maven migration and C client To: DevZooKeeper Content-Type: text/plain; charset="UTF-8" Spotbugs: https://github.com/apache/zookeeper/pull/742 Enrico Il giorno gio 20 dic 2018 alle ore 15:09 Norbert Kalmar ha scritto: > > Here's the PR, open for feedback! :) > https://github.com/apache/zookeeper/pull/741 > > Regards, > Norbert > > On Thu, Dec 20, 2018 at 2:47 PM Enrico Olivelli wrote: > > > New JIRA ticket > > https://issues.apache.org/jira/browse/ZOOKEEPER-3226 > > > > I have assigned it to you Norbert as you are working on it. > > I can pick it up as well > > > > Enrico > > > > > > Il giorno gio 20 dic 2018 alle ore 14:44 Norbert Kalmar > > ha scritto: > > > > > > Great question Enrico, I also thought about it. > > > > > > There is actually already a "Linux profile", so that tests only run when > > it > > > is on Linux system. I wanted to fine grain thath, as ant checks if the > > > required make commands are available. But for a "quick-fix" I made it so > > > that it only runs on Linux. Then I forgot about it... it should > > definitely > > > be changed. And ant already does something like this (if you don't have > > the > > > required infrastructure, c build will not run.) > > > > > > But just creating a profile for building and testing C client is a good > > > idea, so +1 from my side. > > > > > > > > > > Regards, > > > Norbert > > > > > > On Thu, Dec 20, 2018 at 2:29 PM Enrico Olivelli > > wrote: > > > > > > > Hi, > > > > can't we create a "profile" in order to build and test the C Client ? > > > > > > > > I think that very few developers are working on it, it is only a > > > > burden for Java developers. > > > > > > > > CI will build and run tests > > > > > > > > Thoughts ? > > > > > > > > Enrico > > > > > >