From dev-return-76489-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org  Thu Dec  6 03:24:46 2018
Return-Path: <dev-return-76489-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx-eu-01.ponee.io (Postfix) with SMTP id B0C4918062B
	for <archive-asf-public@cust-asf.ponee.io>; Thu,  6 Dec 2018 03:24:45 +0100 (CET)
Received: (qmail 34078 invoked by uid 500); 6 Dec 2018 02:24:44 -0000
Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@zookeeper.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@zookeeper.apache.org>
List-Post: <mailto:dev@zookeeper.apache.org>
List-Id: <dev.zookeeper.apache.org>
Reply-To: dev@zookeeper.apache.org
Delivered-To: mailing list dev@zookeeper.apache.org
Received: (qmail 34060 invoked by uid 99); 6 Dec 2018 02:24:43 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Dec 2018 02:24:43 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id DC3B6E116E; Thu,  6 Dec 2018 02:24:43 +0000 (UTC)
From: hanm <git@git.apache.org>
To: dev@zookeeper.apache.org
Reply-To: dev@zookeeper.apache.org
References: <git-pr-703-zookeeper@git.apache.org>
In-Reply-To: <git-pr-703-zookeeper@git.apache.org>
Subject: [GitHub] zookeeper pull request #703: [ZOOKEEPER-1818] Correctly handle potential inc...
Content-Type: text/plain
Message-Id: <20181206022443.DC3B6E116E@git1-us-west.apache.org>
Date: Thu,  6 Dec 2018 02:24:43 +0000 (UTC)

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/703#discussion_r239309222
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java ---
    @@ -1023,9 +1016,9 @@ else if (validVoter(n.sid) && validVoter(n.leader)) {
                                  */
                                 if (n == null) {
                                     setPeerState(proposedLeader, voteSet);
    -
                                     Vote endVote = new Vote(proposedLeader,
    -                                        proposedZxid, proposedEpoch);
    +                                        proposedZxid, logicalclock.get(), 
    --- End diff --
    
    sgtm to keep consistent with existing code style.


---