zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #680: ZOOKEEPER-3174: Quorum TLS - support reloading trust/k...
Date Mon, 10 Dec 2018 17:28:31 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/680
  
    @ivmaykov For the future, I think it's more convenient for reviewers if you submit your
commits separately instead of squashing them. Especially if you provide some feedback on code
review, it's hard to locate new changes if everything is in a single patch. Commit script
will squash all them eventually, so it doesn't really matter in PRs.


---

Mime
View raw message