zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From enixon <...@git.apache.org>
Subject [GitHub] zookeeper pull request #628: ZOOKEEPER-3140: Allow Followers to host Observe...
Date Thu, 06 Dec 2018 00:52:47 GMT
GitHub user enixon reopened a pull request:

    https://github.com/apache/zookeeper/pull/628

    ZOOKEEPER-3140: Allow Followers to host Observers

    Creates a new abstraction, LearnerMaster, to represent the portions of the Leader logic
that are used in LearnerHandler. Leader implements LearnerMaster and a new class ObserverMaster
implements LearnerMaster. Followers have the option of instantiating a ObserverMaster thread
when they assume their role and so support Learner traffic.
    
    A new parameter 'observerMasterPort' is used to control which Follower instances host
Observers.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/enixon/zookeeper learner-master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/628.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #628
    
----
commit ab5be29541e9968654855115f654207c04e8f9f6
Author: Brian Nixon <nixon@...>
Date:   2018-09-12T21:07:22Z

    ZOOKEEPER-3140: Allow Followers to host Observers

commit 1f915d4e1b9b7d4eab67c0117bc668018ab0e791
Author: Brian Nixon <nixon@...>
Date:   2018-09-15T00:12:40Z

    address the findbugs nits

commit 0e522c9e572d6ef0732cee5defe84a614598442c
Author: Brian Nixon <nixon@...>
Date:   2018-09-27T01:11:22Z

    add comments and address style nits

commit a9cc50fef0921e5b3b390eface3c0401c3fb67dc
Author: Brian Nixon <nixon@...>
Date:   2018-09-27T22:41:39Z

    fix flaky test ObserverMasterTest::testAdminCommands

commit 3f453143d900624841d4d3ba1cd3e8a8ca227ab5
Author: Brian Nixon <nixon@...>
Date:   2018-10-09T22:54:17Z

    address Michael's initial feedback
    
    todo
     - add documentation to zookeeper-docs/src/documentation/content/xdocs/zookeeperObservers.xml
to match https://jira.apache.org/jira/browse/ZOOKEEPER-3140 description
     - rework method docs in Learner to reflect that Followers still connect to the Leader
(not to generic LearnerMaster's)

commit 534eba61c79e933f0fdc54961ffb33dac8d5da0b
Author: Brian Nixon <nixon@...>
Date:   2018-10-10T00:55:07Z

    fix 50% failure rate of ObserverMasterTest::testAdminCommands

commit 332ade54b4f314b6e9084b4781da9015f1d8a13f
Author: Brian Nixon <nixon@...>
Date:   2018-10-22T23:45:33Z

    add expanded documentation to zookeeperObservers.xml and Learner.java

----


---

Mime
View raw message