From dev-return-76271-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Sun Nov 25 06:16:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 013F118062B for ; Sun, 25 Nov 2018 06:16:03 +0100 (CET) Received: (qmail 87785 invoked by uid 500); 25 Nov 2018 05:16:02 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 87774 invoked by uid 99); 25 Nov 2018 05:16:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 25 Nov 2018 05:16:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3E232C2BF1 for ; Sun, 25 Nov 2018 05:16:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BKy8rEn6C2MK for ; Sun, 25 Nov 2018 05:16:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BA9415FD0D for ; Sun, 25 Nov 2018 05:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4118AE00E1 for ; Sun, 25 Nov 2018 05:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 055C121096 for ; Sun, 25 Nov 2018 05:16:00 +0000 (UTC) Date: Sun, 25 Nov 2018 05:16:00 +0000 (UTC) From: "Michael K. Edwards (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-3198) Handle port-binding failures in a systematic and documented fashion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16698065#comment-16698065 ] Michael K. Edwards commented on ZOOKEEPER-3198: ----------------------------------------------- An attempt (as yet, not very successful) to plumb BindExceptions up the stack is in https://github.com/mkedwards/zookeeper/tree/broken-bind-3.5 . I'm currently foundering on test cases that call ReconfigTest.testPortChangeToBlockedPort(). > Handle port-binding failures in a systematic and documented fashion > ------------------------------------------------------------------- > > Key: ZOOKEEPER-3198 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3198 > Project: ZooKeeper > Issue Type: Improvement > Affects Versions: 3.5.3, 3.6.0, 3.4.13 > Reporter: Michael K. Edwards > Priority: Major > Fix For: 3.6.0, 3.5.5, 3.4.14 > > > Many test failures appear to result from bind failures due to port conflicts. This can arise in normal use as well. Presently the code swallows the exception (with an error log) at a low level. It would probably be useful to throw the exception far enough up the stack to trigger retry with a new port (in tests) or a high-level (perhaps even fatal) error message (in normal use). -- This message was sent by Atlassian JIRA (v7.6.3#76005)