From dev-return-76108-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Nov 22 00:32:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 013BD18067B for ; Thu, 22 Nov 2018 00:32:04 +0100 (CET) Received: (qmail 8438 invoked by uid 500); 21 Nov 2018 23:32:04 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 8387 invoked by uid 99); 21 Nov 2018 23:32:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2018 23:32:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 6C47D191C29 for ; Wed, 21 Nov 2018 23:32:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id jRyN1oK8PZI5 for ; Wed, 21 Nov 2018 23:32:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 917CA6227F for ; Wed, 21 Nov 2018 23:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0B1C7E12FE for ; Wed, 21 Nov 2018 23:32:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 51BB723FA7 for ; Wed, 21 Nov 2018 23:32:00 +0000 (UTC) Date: Wed, 21 Nov 2018 23:32:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: dev@zookeeper.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (ZOOKEEPER-2019) Unhandled exception when setting invalid limits data in /zookeeper/quota/some/path/zookeeper_limits MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/ZOOKEEPER-2019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16695367#comment-16695367 ] Hadoop QA commented on ZOOKEEPER-2019: -------------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12670891/ZOOKEEPER-2019-v3.patch against trunk revision 1507f67a06175155003722297daeb60bc912af1d. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3712//console This message is automatically generated. > Unhandled exception when setting invalid limits data in /zookeeper/quota/some/path/zookeeper_limits > ---------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-2019 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2019 > Project: ZooKeeper > Issue Type: Bug > Components: server > Reporter: Raul Gutierrez Segales > Assignee: Raul Gutierrez Segales > Priority: Major > Fix For: 3.6.0, 3.5.5 > > Attachments: ZOOKEEPER-2019-v2.patch, ZOOKEEPER-2019-v3.patch, ZOOKEEPER-2019-ver1.patch, ZOOKEEPER-2019.patch, ZOOKEEPER-2019.patch > > > If you have quotas properly set for a given path, i.e.: > {noformat} > create /zookeeper/quota/test/zookeeper_limits 'count=1,bytes=100' > create /zookeeper/quota/test/zookeeper_stats 'count=1,bytes=100' > {noformat} > and then you update the limits znode with bogus data, i.e.: > {noformat} > set /zookeeper/quota/test/zookeeper_limits '' > {noformat} > you'll crash the cluster because IllegalArgumentException isn't handled when dealing with quotas znodes: > https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L379 > https://github.com/apache/zookeeper/blob/ZOOKEEPER-823/src/java/main/org/apache/zookeeper/server/DataTree.java#L425 > We should handle IllegalArgumentException. Optionally, we should also throw BadArgumentsException from PrepRequestProcessor. > Review Board: https://reviews.apache.org/r/25968/ -- This message was sent by Atlassian JIRA (v7.6.3#76005)