From dev-return-76054-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Nov 21 17:41:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C44D0180668 for ; Wed, 21 Nov 2018 17:41:17 +0100 (CET) Received: (qmail 88929 invoked by uid 500); 21 Nov 2018 16:41:16 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 88918 invoked by uid 99); 21 Nov 2018 16:41:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Nov 2018 16:41:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 12ED0E00A4; Wed, 21 Nov 2018 16:41:16 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are failing... Content-Type: text/plain Message-Id: <20181121164116.12ED0E00A4@git1-us-west.apache.org> Date: Wed, 21 Nov 2018 16:41:16 +0000 (UTC) Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/700 @hanm The issue with Java 11 builds is the refactoring that was made in NIO from Java 11: https://www.oracle.com/technetwork/java/javase/11-relnote-issues-5012449.html#JDK-8198562 The key part is: > Closing a connected SocketChannel that is registered with a Selector will now consistently delay closing the underlying connection until the closed channel is flushed from all selectors that it is registered with. In other words, we have to close all registered Selectors to properly close the socket. Therefore `tryClose(oldSS)` on its own is not enough. ---