From dev-return-75867-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Nov 15 02:54:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 50B73180676 for ; Thu, 15 Nov 2018 02:54:15 +0100 (CET) Received: (qmail 3251 invoked by uid 500); 15 Nov 2018 01:54:14 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 3178 invoked by uid 99); 15 Nov 2018 01:54:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Nov 2018 01:54:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 166D5E12D3; Thu, 15 Nov 2018 01:54:13 +0000 (UTC) From: lvfangmin To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and... Content-Type: text/plain Message-Id: <20181115015413.166D5E12D3@git1-us-west.apache.org> Date: Thu, 15 Nov 2018 01:54:13 +0000 (UTC) Github user lvfangmin commented on the issue: https://github.com/apache/zookeeper/pull/689 @anmolnar that's a good point, I think the reason we didn't use ZooKeeperThread or ZooKeeperCriticalThread is because we don't expect to exit abnormally from the WatcherCleaner thread, which is true for now. But I think it's better to use ZooKeeperThread or even ZooKeeperCriticalThread to cover future changes which might cause the thread exit abnormally. ---