From dev-return-75813-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Nov 14 02:51:08 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 61EF0180676 for ; Wed, 14 Nov 2018 02:51:08 +0100 (CET) Received: (qmail 10167 invoked by uid 500); 14 Nov 2018 01:51:07 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 9520 invoked by uid 99); 14 Nov 2018 01:51:06 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Nov 2018 01:51:06 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A863CE12B8; Wed, 14 Nov 2018 01:51:05 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #669: ZOOKEEPER-3152: Port ZK netty stack to netty4 Content-Type: text/plain Message-Id: <20181114015105.A863CE12B8@git1-us-west.apache.org> Date: Wed, 14 Nov 2018 01:51:05 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/669#discussion_r233288683 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java --- @@ -103,71 +105,102 @@ boolean isConnected() { // Assuming that isConnected() is only used to initiate connection, // not used by some other connection status judgement. - return channel != null; + connectLock.lock(); + try { + return channel != null || connectFuture != null; --- End diff -- Why would you like to check `connectFuture` too? ---