From dev-return-75800-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Nov 13 22:09:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id CE4AE18062B for ; Tue, 13 Nov 2018 22:09:04 +0100 (CET) Received: (qmail 45378 invoked by uid 500); 13 Nov 2018 21:09:03 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 45367 invoked by uid 99); 13 Nov 2018 21:09:03 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Nov 2018 21:09:03 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 251C3E00AA; Tue, 13 Nov 2018 21:09:03 +0000 (UTC) From: yisong-yue To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the... Content-Type: text/plain Message-Id: <20181113210903.251C3E00AA@git1-us-west.apache.org> Date: Tue, 13 Nov 2018 21:09:03 +0000 (UTC) Github user yisong-yue commented on the issue: https://github.com/apache/zookeeper/pull/690 @anmolnar One drawback I see with this structure is that it makes it harder to dynamically pick deserialization mode based on a snapshot's filename, since `FileSnap` manages a whole `snapDir` directory now. Maybe we should separate directory management logic from snapshot file (de)serialization in FileSnap class. ---