From dev-return-75700-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Thu Nov 8 20:20:42 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D7E4F180671 for ; Thu, 8 Nov 2018 20:20:41 +0100 (CET) Received: (qmail 1096 invoked by uid 500); 8 Nov 2018 19:20:35 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 1076 invoked by uid 99); 8 Nov 2018 19:20:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2018 19:20:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 276A2E0056; Thu, 8 Nov 2018 19:20:35 +0000 (UTC) From: tumativ To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper issue #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thread and... Content-Type: text/plain Message-Id: <20181108192035.276A2E0056@git1-us-west.apache.org> Date: Thu, 8 Nov 2018 19:20:35 +0000 (UTC) Github user tumativ commented on the issue: https://github.com/apache/zookeeper/pull/689 @asfgit Thanks for reviewing. - I see that there is a gap in API contract that allowing the dead watcher even cleaner thread is not running. I hope it is the burden on GC even it is GCed. - We can interrupt the cleaner thread, but It is fine if it is waiting for minimum threshold dead watchers at the time of interrupting. The thread is marked as interrupted if it is not really waiting and the exception will be thrown any subsequent wait. I think the prediction is important at least in thread communication. ---