From dev-return-75664-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Wed Nov 7 18:52:01 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5EB52180649 for ; Wed, 7 Nov 2018 18:52:00 +0100 (CET) Received: (qmail 92701 invoked by uid 500); 7 Nov 2018 17:51:59 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 92690 invoked by uid 99); 7 Nov 2018 17:51:58 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2018 17:51:58 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 80591E0A2E; Wed, 7 Nov 2018 17:51:58 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr... Content-Type: text/plain Message-Id: <20181107175158.80591E0A2E@git1-us-west.apache.org> Date: Wed, 7 Nov 2018 17:51:58 +0000 (UTC) Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/689#discussion_r231610533 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java --- @@ -50,6 +50,8 @@ private volatile boolean stopped = false; private final Object cleanEvent = new Object(); + private final Object produserAndConsumerLock = new Object(); --- End diff -- Why do you need this explicit lock object instead if `totalDeadWatchers`? ---