From dev-return-75381-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Fri Nov 2 02:34:35 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0FFC2180652 for ; Fri, 2 Nov 2018 02:34:34 +0100 (CET) Received: (qmail 17415 invoked by uid 500); 2 Nov 2018 01:34:34 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 17404 invoked by uid 99); 2 Nov 2018 01:34:33 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 02 Nov 2018 01:34:33 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 41621DFEB8; Fri, 2 Nov 2018 01:34:32 +0000 (UTC) From: ivmaykov To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org References: In-Reply-To: Subject: [GitHub] zookeeper pull request #: Content-Type: text/plain Message-Id: <20181102013433.41621DFEB8@git1-us-west.apache.org> Date: Fri, 2 Nov 2018 01:34:32 +0000 (UTC) Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31143262 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java on line 489: ZKConfig will get the value from system properties. In the next PR this is changed - you can create a X509Util with a ZKConfig parameter, in which case it will be used here. ---