zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Chernatsky (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ZOOKEEPER-3191) Code cleaned up
Date Thu, 15 Nov 2018 15:25:00 GMT
Artem Chernatsky created ZOOKEEPER-3191:

             Summary: Code cleaned up
                 Key: ZOOKEEPER-3191
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3191
             Project: ZooKeeper
          Issue Type: Improvement
            Reporter: Artem Chernatsky

Working on some feature for Zookeeper I've found strange and redundant code in several places,
 * [if true set true|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/Leader.java#L388-L398]
 * [redundant code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java#L124-L126]
 * [redundant code|https://github.com/apache/zookeeper/blob/a859410aea35dfef5fa54c99fb8a5bfc81f1a46b/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java#L462]

It makes difficult working with code. So maybe it should be cleaned up?

This message was sent by Atlassian JIRA

View raw message