zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tumati Venky <tuma...@gmail.com>
Subject Re: [GitHub] zookeeper pull request #711: ZOOKEEPER-3177. Revert globalOutstandingLimit r...
Date Wed, 21 Nov 2018 13:23:47 GMT
Hi All,

I gave PR to resolve the findbug issues introduced in master.

Here is the PR.

https://github.com/apache/zookeeper/pull/712


Thanks,
Tumati



On Wed, Nov 21, 2018 at 6:51 PM eolivelli <git@git.apache.org> wrote:

> Github user eolivelli commented on a diff in the pull request:
>
>     https://github.com/apache/zookeeper/pull/711#discussion_r235383411
>
>     --- Diff:
> zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
> ---
>     @@ -864,6 +860,17 @@ public static int getSnapCount() {
>              }
>          }
>
>     +    public int getGlobalOutstandingLimit() {
>     +        String sc = System.getProperty(GLOBAL_OUTSTANDING_LIMIT);
>     --- End diff --
>
>     are we reading the system property and parsing the value at every call
> of shouldThrottle ?
>     can't we cache the value ?
>
>
> ---
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message