zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Enrico Olivelli <eolive...@gmail.com>
Subject Re: Re: asfgit commenting on PRs
Date Wed, 07 Nov 2018 18:37:02 GMT
Now it seems okay.
Let me know if there are problems.
The docs about the plugin are not very clear.

Cheers
Enrico

Il mar 6 nov 2018, 21:10 Enrico Olivelli <eolivelli@gmail.com> ha scritto:

> I am not sure what is adding that comment.
> I will dig
>
> Enrico
>
>
> Il mar 6 nov 2018, 21:04 Michael Han <hanm@apache.org> ha scritto:
>
>> +1 on the idea of silencing the comments from asfgit bot.
>>
>> Hi Enrico - I am still seeing the bot commenting on builds triggered by
>> new
>> commits after you making the change.
>> An example just a second ago:
>> https://github.com/apache/zookeeper/pull/679
>>
>> On Tue, Nov 6, 2018 at 4:02 AM Enrico Olivelli <eolivelli@gmail.com>
>> wrote:
>>
>> > I have unchecked the "Add test result one liner" flag in the PR builder
>> Job
>> > https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/
>> >
>> > let's see how it feels now
>> >
>> > Enrico
>> >
>> >
>> > Il giorno mar 6 nov 2018 alle ore 03:44 毛蛤丝
>> > <maoling199210191@sina.com> ha scritto:
>> > >
>> > > +1,for removing the asfgit successful build comments.
>> > >
>> > > --------------------------------
>> > >
>> > > Best regards
>> > > maoling
>> > > Beijing,China
>> > >
>> > >
>> > > ----- 原始邮件 -----
>> > > 发件人:Enrico Olivelli <eolivelli@gmail.com>
>> > > 收件人:dev@zookeeper.apache.org
>> > > 主题:Re: asfgit commenting on PRs
>> > > 日期:2018年11月06日 04点57分
>> > >
>> > > Il lun 5 nov 2018, 21:28 Andor Molnar <andor@apache.org> ha scritto:
>> > > > I also feel the comments redundant.
>> > > > Enrico - shall we remove this?
>> > > >
>> > > I will check, it should be a flag on job config
>> > > Enrico
>> > > > Andor
>> > > >
>> > > >
>> > > >
>> > > > > On 2018. Nov 5., at 12:24, Norbert Kalmar
>> > <nkalmar@cloudera.com.INVALID>
>> > > > wrote:
>> > > > >
>> > > > > Hi all,
>> > > > >
>> > > > > One of the recent development was that asfgit now comments on
the
>> PRs
>> > > > every
>> > > > > successful builds.
>> > > > > But we do have the same information under "Show all checks".
(This
>> > might
>> > > > be
>> > > > > gone after closing the PR though).
>> > > > >
>> > > > > I wouldn't mind the extra commit, but on github, in
>> > > > > https://github.com/apache/zookeeper/pulls, we have multiple
>> comments
>> > > > > showing under every PR. Before this, for me at least, I used
this
>> to
>> > > > > quickly identify the PRs which haven't been reviewed by anyone
>> > (having 0
>> > > > or
>> > > > > 1 comments). Or to see quickly if something is getting a lot
of
>> > attention
>> > > > > lately, or getting updates etc.
>> > > > >
>> > > > > This was a convenient thing for me, of course not a feature I
>> can't
>> > live
>> > > > > without. I just wanted to ask other devs view on this.
>> > > > >
>> > > > > So, what's your view? :)
>> > > > >
>> > > > > Regards,
>> > > > > Norbert
>> > > >
>> > > > --
>> > > -- Enrico Olivelli
>> >
>>
> --
>
>
> -- Enrico Olivelli
>
-- 


-- Enrico Olivelli

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message