zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #703: [ZOOKEEPER-1818] Correctly handle potential inc...
Date Thu, 29 Nov 2018 06:45:29 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/703#discussion_r237367990
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
    @@ -1989,6 +1989,38 @@ private boolean updateVote(long designatedLeader, long zxid){
         /**
          * Updates leader election info to avoid inconsistencies when
          * a new server tries to join the ensemble.
    +     *
    +     * Here is the inconsistency scenario we try to solve by updating the peer 
    --- End diff --
    
    awesome comments.


---

Mime
View raw message