zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #703: [ZOOKEEPER-1818] Correctly handle potential inc...
Date Thu, 29 Nov 2018 06:45:29 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/703#discussion_r237367661
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/FastLeaderElection.java
---
    @@ -1023,9 +1016,9 @@ else if (validVoter(n.sid) && validVoter(n.leader)) {
                                  */
                                 if (n == null) {
                                     setPeerState(proposedLeader, voteSet);
    -
                                     Vote endVote = new Vote(proposedLeader,
    -                                        proposedZxid, proposedEpoch);
    +                                        proposedZxid, logicalclock.get(), 
    --- End diff --
    
    nit: indentations looks a little bit off here?


---

Mime
View raw message