zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #722: [ZOOKEEPER-3203] Tracking the number of non vot...
Date Wed, 28 Nov 2018 22:35:42 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/722#discussion_r237288886
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/LeaderBean.java
---
    @@ -51,6 +51,15 @@ public String followerInfo() {
             return sb.toString();
         }
     
    +    @Override
    +    public String nonVotingFollowerInfo() {
    +        StringBuilder sb = new StringBuilder();
    +        for (LearnerHandler handler : leader.getNonVotingFollowers()) {
    +            sb.append(handler.toString()).append("\n");
    --- End diff --
    
    That's a fair point, but I'd like to keep the same behavior in this patch as what we're
doing now for the followInfo in this LeaderBean.


---

Mime
View raw message