zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #679: ZOOKEEPER-3172: Quorum TLS - fix port unification to a...
Date Mon, 26 Nov 2018 21:57:38 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/679
  
    @ivmaykov I'm not a fan of them, but understand the intention and can't figure out a more
straightforward way to test the behaviour. So let's go with them.
    
    What do you think of renaming them to something like `testTLSDetectionNonBlocking(Non)StrictServer`?
    I would also rephrase the comment to emphasize that the tests are intended to validate
that TLS detection is non-blocking, so it's safe to getInputStream() on the accept thread.
    
    These are not really denial-of-service tests IMHO. Thoughts?


---

Mime
View raw message