zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...
Date Mon, 26 Nov 2018 00:32:46 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/689#discussion_r236098795
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
    @@ -161,10 +163,10 @@ public void doWork() throws Exception {
                             long startTime = Time.currentElapsedTime();
                             listener.processDeadWatchers(snapshot);
                             long latency = Time.currentElapsedTime() - startTime;
    -                        LOG.info("Takes {} to process {} watches", latency, total);
    +                        LOG.info("Takes {} to process {} watchers", latency, total);
    --- End diff --
    
    Watches seems to be more reasonable here, watcher maps to a single client session, and
it can watch multiple paths, so have multiple watches on a single watcher, the total value
is the total watches count not watcher.


---

Mime
View raw message