zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lavacat <...@git.apache.org>
Subject [GitHub] zookeeper pull request #721: ZOOKEEPER-3046: wait for clients to reconnect a...
Date Sun, 25 Nov 2018 23:09:39 GMT
Github user lavacat commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/721#discussion_r236095252
  
    --- Diff: zookeeper-server/src/test/java/org/apache/zookeeper/test/DisconnectedWatcherTest.java
---
    @@ -221,6 +228,7 @@ public void testManyChildWatchersAutoReset() throws Exception {
             watcher.waitForDisconnected(30000);
             startServer();
             watcher.waitForConnected(30000);
    +        watcher1.waitForConnected(30000);
    --- End diff --
    
    If this is fixing this test - that's great.
    Trying to understand why. If zk1 isn't connected, should we get CONNECTIONLOSS on line
237 zk1.create?
    Here is an example and I don't see it.
    https://builds.apache.org/job/ZooKeeper_branch35_java10/263/testReport/junit/org.apache.zookeeper.test/DisconnectedWatcherTest/testManyChildWatchersAutoReset/
    
    Good improvement anyway, I think should be merged.


---

Mime
View raw message