zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...
Date Sun, 25 Nov 2018 07:36:01 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/689#discussion_r236063171
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
    @@ -102,12 +103,13 @@ public void addDeadWatcher(int watcherBit) {
                     totalDeadWatchers.get() >= maxInProcessingDeadWatchers) {
                 try {
                     RATE_LOGGER.rateLimitLog("Waiting for dead watchers cleaning");
    -                synchronized(totalDeadWatchers) {
    -                    totalDeadWatchers.wait(100);
    +                synchronized(processingCompletedEvent) {
    +                	processingCompletedEvent.wait(100);
    --- End diff --
    
    Can we change this with 4 extra white spaces relative to the synchronized statement?


---

Mime
View raw message