zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkedwards <...@git.apache.org>
Subject [GitHub] zookeeper pull request #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addres...
Date Wed, 21 Nov 2018 16:44:07 GMT
Github user mkedwards commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/707#discussion_r235463520
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
    @@ -755,39 +769,55 @@ public void recreateSocketAddresses(long id) {
             }
         }
     
    -    public InetSocketAddress getQuorumAddress(){
    -        synchronized (QV_LOCK) {
    -            return myQuorumAddr;
    +    InetSocketAddress getQuorumAddress(){
    --- End diff --
    
    Good suggestion.  Done.


---

Mime
View raw message