zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mkedwards <...@git.apache.org>
Subject [GitHub] zookeeper issue #707: [ZOOKEEPER-2778] QuorumPeer: encapsulate addresses
Date Wed, 21 Nov 2018 16:39:26 GMT
Github user mkedwards commented on the issue:

    > `private` should be changed back to `public `
    > Jenkins complains about [this](https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/2685/artifact/patchprocess/trunkJavacWarnings.txt)
    Okay.  It might be better for the tests to be in the same package as the implementation,
so these methods can be package-private; but that's out of scope for this PR.  I'll change
them back to `public`.


View raw message