zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper issue #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are failing...
Date Wed, 21 Nov 2018 16:28:31 GMT
Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/700
  
    >> This will keep the original behaviour of eagerly registering the selector in
the constructor and addresses your concerns.
    
    LGTM, thanks for doing this!
    
    >> ReconfigTest.testPortChangeToBlockedPort failed, becuase it expects the original
port to be released even if the new port cannot be bound. 
    
    The proposed change looks reasonable. Though I am wondering why the current logic would
fail this test: if new port fails to bind, the old port will be closed as part of `tryClose(oldSS);`
in the `catch` block. Mind to elaborate a little bit regarding which cases the current code
fails to close the old socket?
    
    



---

Mime
View raw message