zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...
Date Tue, 20 Nov 2018 05:17:21 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/700#discussion_r234871411
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
    @@ -209,6 +209,8 @@ public void run() {
                             LOG.warn("Ignoring unexpected exception", e);
                         }
                     }
    +            } catch (IOException e) {
    +                LOG.error("Exception when running accept thread. Unable to register selector?",
e);
    --- End diff --
    
    I am also curious why 3.4 does not have this test issue. Technically 3.4 works similar
with master and 3.5 w.r.t. the selector registration - both register selector before the server
factory is 'started' (though in 3.5 and trunk, we made `NIOServerCnxn` multi-threaded`).


---

Mime
View raw message