zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From asdf2014 <...@git.apache.org>
Subject [GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...
Date Sun, 18 Nov 2018 14:15:24 GMT
Github user asdf2014 commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/294#discussion_r234446570
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
    @@ -71,7 +71,7 @@ public static void registerLog4jMBeans() throws JMException {
                     // org.apache.log4j.jmx.HierarchyDynamicMBean hdm = new org.apache.log4j.jmx.HierarchyDynamicMBean();
                     Object hdm = Class.forName("org.apache.log4j.jmx.HierarchyDynamicMBean").getDeclaredConstructor().newInstance();
     
    -                ObjectName mbo = new ObjectName("log4j:hiearchy=default");
    +                ObjectName mbo = new ObjectName("log4j:hierarchy=default");
    --- End diff --
    
    Hi, @eolivelli . Thanks for your reviewing. Indeed, turning it into a configurable one
would be very helpful in upgrading an integrated system. So, let's be clear, should we add
a new JVM option or add a new environment variable to the operating system?


---

Mime
View raw message