zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eolivelli <...@git.apache.org>
Subject [GitHub] zookeeper pull request #294: ZOOKEEPER-2822: Wrong `ObjectName` about `MBean...
Date Sun, 18 Nov 2018 06:13:51 GMT
Github user eolivelli commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/294#discussion_r234430242
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java ---
    @@ -71,7 +71,7 @@ public static void registerLog4jMBeans() throws JMException {
                     // org.apache.log4j.jmx.HierarchyDynamicMBean hdm = new org.apache.log4j.jmx.HierarchyDynamicMBean();
                     Object hdm = Class.forName("org.apache.log4j.jmx.HierarchyDynamicMBean").getDeclaredConstructor().newInstance();
     
    -                ObjectName mbo = new ObjectName("log4j:hiearchy=default");
    +                ObjectName mbo = new ObjectName("log4j:hierarchy=default");
    --- End diff --
    
    Is change may have an impact on integrated systems.
    Maybe we could make this name configurable so that people will be able to revert the name.
    This change can be only in master (3.6.0) as it is a public configuration/API change


---

Mime
View raw message