zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...
Date Sat, 17 Nov 2018 07:07:38 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/689#discussion_r234399479
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
    @@ -177,6 +180,7 @@ public void shutdown() {
             stopped = true;
             deadWatchers.clear();
             cleaners.stop();
    +        super.interrupt();
    --- End diff --
    
    Maybe just change it to this.interrupt(), since we're not overwriting it.


---

Mime
View raw message