zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lvfangmin <...@git.apache.org>
Subject [GitHub] zookeeper pull request #689: ZOOKEEPER-3183:Notifying the WatcherCleaner thr...
Date Sat, 17 Nov 2018 07:07:38 GMT
Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/689#discussion_r234399372
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/watch/WatcherCleaner.java
---
    @@ -50,6 +50,8 @@
     
         private volatile boolean stopped = false;
         private final Object cleanEvent = new Object();
    +    private final Object produserAndConsumerLock = new Object();
    --- End diff --
    
    Can you give it a more explicit name? produserAndConsumerLock seems too general here.


---

Mime
View raw message