zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yisong-yue <...@git.apache.org>
Subject [GitHub] zookeeper issue #690: ZOOKEEPER-3179: Add snapshot compression to reduce the...
Date Tue, 13 Nov 2018 21:09:03 GMT
Github user yisong-yue commented on the issue:

    https://github.com/apache/zookeeper/pull/690
  
    @anmolnar 
    One drawback I see with this structure is that it makes it harder to dynamically pick
deserialization mode based on a snapshot's filename, since `FileSnap` manages a whole `snapDir`
directory now. Maybe we should separate directory management logic from snapshot file (de)serialization
in FileSnap class.


---

Mime
View raw message