zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #700: ZOOKEEPER-1441 - JAVA 11 - Some test cases are ...
Date Mon, 12 Nov 2018 22:56:00 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/700#discussion_r232840801
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/NIOServerCnxnFactory.java
---
    @@ -181,7 +181,7 @@ protected void fastCloseSock(SocketChannel sc) {
          */
         private class AcceptThread extends AbstractSelectThread {
             private final ServerSocketChannel acceptSocket;
    -        private final SelectionKey acceptKey;
    +        private SelectionKey acceptKey;
    --- End diff --
    
    You're right. However the only access in this class is called from the `select()` method
which is called only after the registration is successful, so I think we're fine.


---

Mime
View raw message