zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Date Tue, 06 Nov 2018 01:38:21 GMT
Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/684#discussion_r230973904
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ResponseCache.java
---
    @@ -0,0 +1,84 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.server;
    +
    +import java.util.Collections;
    +import java.util.LinkedHashMap;
    +import java.util.Map;
    +
    +import org.apache.jute.Record;
    +import org.apache.zookeeper.data.Stat;
    +
    +@SuppressWarnings("serial")
    +public class ResponseCache {
    +    private static final int DEFAULT_RESPONSE_CACHE_SIZE = 400;
    --- End diff --
    
    Agreed. You might want to add some useful comment here.


---

Mime
View raw message