zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From anmolnar <...@git.apache.org>
Subject [GitHub] zookeeper issue #686: Zookeeper 3167
Date Tue, 06 Nov 2018 00:01:27 GMT
Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/686
  
    @TyqITstudent Please create pull request for the master branch first. We can talk about
integrating this into 3.5, but we don't accept new features for 3.4
    
    Would be better to use `key.startsWith(path)` instead of contains to make sure the path
starts with the parent's.
    
    Have you considered limiting the access to this command? I'm not sure if it's needed (say
we've merged the recursive flag of `setAcl` command recently which didn't have limits either),
but this command could be too expensive, if the ensemble has millions of nodes. As a consequence
the command can be used for a DOS attach, similarly to 4lw commands which have been blacklisted
previously.


---

Mime
View raw message