zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivmaykov <...@git.apache.org>
Subject [GitHub] zookeeper pull request #:
Date Fri, 02 Nov 2018 16:12:46 GMT
Github user ivmaykov commented on the pull request:

    https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151782
  
    In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java:
    In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java on line 544:
    That seems a bit fragile and could potentially introduce bugs, since we will need an explicit
shutdown method where none existed before. Since we are currently targeting Java 8, can I
keep the finalizer in this PR and fix it in a later PR + JIRA?


---

Mime
View raw message