zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tumativ <...@git.apache.org>
Subject [GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...
Date Fri, 02 Nov 2018 01:52:00 GMT
Github user tumativ commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/678#discussion_r230251259
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java
---
    @@ -0,0 +1,67 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.zookeeper.common;
    +
    +import java.io.File;
    +import java.io.FileInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.security.GeneralSecurityException;
    +import java.security.KeyStore;
    +
    +/**
    + * Implementation of {@link FileKeyStoreLoader} that loads from JKS files.
    + */
    +class JKSFileLoader extends FileKeyStoreLoader {
    +    private static final char[] EMPTY_CHAR_ARRAY = new char[0];
    +
    +    private JKSFileLoader(String keyStorePath,
    +                          String trustStorePath,
    +                          String keyStorePassword,
    +                          String trustStorePassword) {
    +        super(keyStorePath, trustStorePath, keyStorePassword, trustStorePassword);
    +    }
    +
    +    @Override
    +    public KeyStore loadKeyStore() throws IOException, GeneralSecurityException {
    +        KeyStore ks = KeyStore.getInstance("JKS");
    --- End diff --
    
    Can we declare global final variable for "JKS"  and refer in code?


---

Mime
View raw message