zookeeper-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hanm <...@git.apache.org>
Subject [GitHub] zookeeper pull request #684: ZOOKEEPER-3180: Add response cache to improve t...
Date Thu, 01 Nov 2018 04:38:59 GMT
Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/684#discussion_r229938031
  
    --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerMetrics.java
---
    @@ -67,7 +67,10 @@
         SNAP_COUNT(new SimpleCounter("snap_count")),
         COMMIT_COUNT(new SimpleCounter("commit_count")),
         CONNECTION_REQUEST_COUNT(new SimpleCounter("connection_request_count")),
    -    BYTES_RECEIVED_COUNT(new SimpleCounter("bytes_received_count"));
    +    BYTES_RECEIVED_COUNT(new SimpleCounter("bytes_received_count")),
    +
    +    RESPONSE_PACKET_CACHE_HITS(new SimpleCounter("response_packet_cache_hits")),
    +    RESPONSE_PACKET_CACHE_MISSING(new SimpleCounter("response_packet_cache_misses"));
    --- End diff --
    
    how well this cache works under different type of workloads, based on the stats here?
(if it's ok to share)


---

Mime
View raw message