From dev-return-74048-archive-asf-public=cust-asf.ponee.io@zookeeper.apache.org Tue Oct 2 15:56:50 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7BCD7180638 for ; Tue, 2 Oct 2018 15:56:49 +0200 (CEST) Received: (qmail 73815 invoked by uid 500); 2 Oct 2018 13:56:48 -0000 Mailing-List: contact dev-help@zookeeper.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zookeeper.apache.org Delivered-To: mailing list dev@zookeeper.apache.org Received: (qmail 73801 invoked by uid 99); 2 Oct 2018 13:56:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Oct 2018 13:56:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 9F0C2DFFAC; Tue, 2 Oct 2018 13:56:47 +0000 (UTC) From: anmolnar To: dev@zookeeper.apache.org Reply-To: dev@zookeeper.apache.org Message-ID: Subject: [GitHub] zookeeper pull request #653: ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest... Content-Type: text/plain Date: Tue, 2 Oct 2018 13:56:47 +0000 (UTC) GitHub user anmolnar opened a pull request: https://github.com/apache/zookeeper/pull/653 ZOOKEEPER-3159. Flaky: ClientRequestTimeoutTest.testClientRequestTimeout Can't see a reason why testing again the create method without packet drop. Timeout scenario has already been tested and this part seem to make the test flaky. Removed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-3159 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/653.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #653 ---- commit 850bcdc8b9d88893901c5e3b53acf4488cf7bd8d Author: Andor Molnar Date: 2018-10-02T13:55:03Z ZOOKEEPER-3159. Removed redundant assert block which usually failing ---- ---